Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev #6

Merged
merged 52 commits into from
Aug 6, 2023
Merged

Merge dev #6

merged 52 commits into from
Aug 6, 2023

Conversation

ten3roberts
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Patch coverage: 78.97% and project coverage change: -0.93% ⚠️

Comparison is base (63e98c6) 80.43% compared to head (2c9223e) 79.51%.
Report is 1 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   80.43%   79.51%   -0.93%     
==========================================
  Files          64       67       +3     
  Lines        4948     5072     +124     
==========================================
+ Hits         3980     4033      +53     
- Misses        968     1039      +71     
Files Changed Coverage Δ
flax-derive/src/lib.rs 0.00% <0.00%> (ø)
src/query/difference.rs 95.83% <ø> (ø)
src/query/topo.rs 80.00% <ø> (-0.49%) ⬇️
src/relation.rs 42.85% <0.00%> (ø)
src/serialize/mod.rs 70.58% <ø> (ø)
src/error.rs 20.83% <20.00%> (+2.08%) ⬆️
src/filter/constant.rs 27.90% <27.90%> (ø)
src/filter/cmp.rs 80.39% <50.00%> (-8.74%) ⬇️
src/system/mod.rs 73.12% <50.00%> (ø)
src/fetch/maybe_mut.rs 36.00% <61.53%> (+1.90%) ⬆️
... and 50 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BREAKING:
`Query<(Component<T>, Mutable<T>), And<All, With>>` will become
`Query<(Component<T>, Mutable<T>), (All, With)>`

This is mostly only relevant if you explicitly store queries, when using
queries the `filter` parameter can be ignored with `_` and is generally
preferred as it allows adding a filter without modifying the argument
type as well.
@ten3roberts ten3roberts merged commit 34b3713 into main Aug 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants